From: Takashi Iwai Subject: Re: [RFC] compress: add support for gapless playback Date: Thu, 07 Feb 2013 12:49:49 +0100 Message-ID: References: <1360074085-562-1-git-send-email-vinod.koul@intel.com> <37A133201056E44A80888420ECA881BF1093DC5F68@EXCMB2.wolfsonmicro.main> <20130207011518.GA30348@opensource.wolfsonmicro.com> <20130207021807.GM3143@intel.com> <20130207113738.GA15824@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D45A52625E6 for ; Thu, 7 Feb 2013 12:49:49 +0100 (CET) In-Reply-To: <20130207113738.GA15824@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Richard Fitzgerald Cc: Vinod Koul , jeeja.kp@intel.com, alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org At Thu, 7 Feb 2013 11:37:38 +0000, Richard Fitzgerald wrote: > > > > 1) Send SNDRV_COMPRESS_NEXT_TRACK > > > 2) Send SNDRV_COMPRESS_DRAIN > > The problem would be in that case the defination of SNDRV_COMPRESS_DRAIN which > > expects the decoder to completely drain its buffers and come to complete halt. > > This would also mean the framework will treat a drained stream as stopped and > > needs a new start. Certainly we dont want that in this case. So we can't use > > SNDRV_COMPRESS_DRAIN to indicate. Yes we can put conditional check but IMO that > > would overtly complicate this. If we are not doing proper drian lets not > > call it that. > > Ok, so let's keep the partial drain but split out the NEXT_TRACK hint so we keep > the two operations separate. It's clearer to understand. NEXT_TRACK tells DSP to > prepare for data for new track, PARTIAL_DRAIN asks DSP when it has played all > data of current track. I don't think that application _must_ drain when doing > gapless, only if it cares to know when DSP reaches the join between tracks. > Possible problem - application calls NEXT_TRACK and PARTIAL_DRAIN when DSP has > already reached end of current track, so what does PARTIAL_DRAIN mean in this > case? Which track is it draining? Maybe define that it always refers to the > track _before_ the most recent NEXT_TRACK call? > > Also can we make metadata a key-pair list as Takashi suggested, with unlimited > length. Something like > > struct snd_compr_metadata_pair { > enum snd_compr_metadata_key key; > u32 value; > }; > > struct snd_compr_metadata { > int count; /* number of actual entries in following array */ > struct snd_compr_metadata_pair *pairs; > }; > > Should we union the u32 value with a u8* buf to allow for any case where the > value needs to be a buffer of binary data? Oh no, don't do it. Never. In general, - Never put types that depending on the architecture in struct passed to ioctls (e.g. long, pointer) - Never use bit fields for ABI - If 64bit value is used, think of alignment; safer to add packed attribute So, in general, use only u32, s16, or whatever, the types with explicit size. Takashi