From: Takashi Iwai Subject: Re: [PATCH 1/2] alsa: compress_core: don't wake up on pause Date: Tue, 12 Jun 2012 18:17:48 +0200 Message-ID: References: <1339497978-12213-1-git-send-email-vinod.koul@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id B6DAD24674 for ; Tue, 12 Jun 2012 18:17:50 +0200 (CEST) In-Reply-To: <1339497978-12213-1-git-send-email-vinod.koul@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com, Namarta Kohli , pierre-louis.bossart@linux.intel.com List-Id: alsa-devel@alsa-project.org At Tue, 12 Jun 2012 16:16:17 +0530, Vinod Koul wrote: > > during pause the core should maintain the status-quo on the device and pointers > and not wake up. If app needs it should call DROP explcitly. > > Signed-off-by: Namarta Kohli > Signed-off-by: Vinod Koul Thanks, applied these now. Takashi > --- > sound/core/compress_offload.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c > index a68aed7..375f7a0 100644 > --- a/sound/core/compress_offload.c > +++ b/sound/core/compress_offload.c > @@ -502,10 +502,8 @@ static int snd_compr_pause(struct snd_compr_stream *stream) > if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING) > return -EPERM; > retval = stream->ops->trigger(stream, SNDRV_PCM_TRIGGER_PAUSE_PUSH); > - if (!retval) { > + if (!retval) > stream->runtime->state = SNDRV_PCM_STATE_PAUSED; > - wake_up(&stream->runtime->sleep); > - } > return retval; > } > > -- > 1.7.0.4 >