From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda/conexant - Add quirks for lenovo notebooks Date: Tue, 18 Oct 2011 12:57:54 +0200 Message-ID: References: <4E9D52EC.5030606@secunet.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A0204244CA for ; Tue, 18 Oct 2011 12:57:56 +0200 (CEST) In-Reply-To: <4E9D52EC.5030606@secunet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Torsten Hilbrich Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 18 Oct 2011 12:20:28 +0200, Torsten Hilbrich wrote: > > The lenovo sandy bridge notebooks (T420, T520, L520) didn't work with > the external sound input and output connectors on the dockig unit > (tested with P/N 45N5887). > > Loading snd-hda-intel with model=thinkpad solved the problem so I > added the accordings quirks to perform that decision automatically > for these specific models. > > Signed-off-by: Torsten Hilbrich Could you check whether model=auto with the latest kernel work? Basically I won't take any more the model-specific quirk but move all to the auto-parser as much as possible. thanks, Takashi > --- > sound/pci/hda/patch_conexant.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > index 502fc94..90a6b98 100644 > --- a/sound/pci/hda/patch_conexant.c > +++ b/sound/pci/hda/patch_conexant.c > @@ -3110,8 +3110,11 @@ static const struct snd_pci_quirk cxt5066_cfg_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x21c5, "Thinkpad Edge 13", CXT5066_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x21c6, "Thinkpad Edge 13", CXT5066_ASUS), > SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD), > + SND_PCI_QUIRK(0x17aa, 0x21ce, "Lenovo T420", CXT5066_THINKPAD), > + SND_PCI_QUIRK(0x17aa, 0x21cf, "Lenovo T520", CXT5066_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x21da, "Lenovo X220", CXT5066_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x21db, "Lenovo X220-tablet", CXT5066_THINKPAD), > + SND_PCI_QUIRK(0x17aa, 0x21de, "Lenovo L520", CXT5066_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo U350", CXT5066_ASUS), > SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo G560", CXT5066_ASUS), > SND_PCI_QUIRK(0x17aa, 0x3938, "Lenovo G565", CXT5066_AUTO), > -- > 1.7.5.4 >