From: Takashi Iwai Subject: Re: [PATCH 1/3] ALSA: usb: move ua101 driver Date: Mon, 01 Mar 2010 15:06:57 +0100 Message-ID: References: <1267194883-6854-1-git-send-email-daniel@caiaq.de> <1267194883-6854-2-git-send-email-daniel@caiaq.de> <4B8BA4A3.1060506@ladisch.de> <20100301140129.GI28972@buzzloop.caiaq.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id CE32C103862 for ; Mon, 1 Mar 2010 15:06:57 +0100 (CET) In-Reply-To: <20100301140129.GI28972@buzzloop.caiaq.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, Clemens Ladisch List-Id: alsa-devel@alsa-project.org At Mon, 1 Mar 2010 15:01:29 +0100, Daniel Mack wrote: > > On Mon, Mar 01, 2010 at 12:27:31PM +0100, Clemens Ladisch wrote: > > Daniel Mack wrote: > > > As part of the USB audio code cleanup, move the non-standard ua101 > > > driver out of the way. > > > > A directory with a single source file in it isn't quite an improvement. > > Please name it "misc" so that other specialized drivers could be put in > > there. > > Ok, will do. However, I wonder which way is best to do that. Given that > you posted patches on top of mine, can I take this as a general > agreement to my changeset? If so, I will just provide a patch on top to > do the ua101 -> misc rename, because otherwise, I would have to rebase > all three patches for that. Well, honestly, I prefer seeing the fixes by Clemens based on the current code, and merge Daniel's refactoring patches after 2.6.34 merge window. Refactoring is a good thing but it can easily introduce any careless bugs (like copy&paste error), and this split action makes really hard to track the changes. Thus I'd like to keep this well ripened before reaching to the Linus tree, not only for a few days. thanks, Takashi