From: Takashi Iwai Subject: Re: [PATCH] Add support for Acer TravelMate and similar laptops Date: Mon, 27 Feb 2006 13:58:36 +0100 Message-ID: References: <44022D35.7050909@akl.lt> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <44022D35.7050909@akl.lt> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Rimas Kudelis Cc: alsa-devel@lists.sourceforge.net, Paulo Matias , Jonathan Woithe List-Id: alsa-devel@alsa-project.org At Mon, 27 Feb 2006 00:35:33 +0200, Rimas Kudelis wrote: > > Hi all, > > Attached here is a patch that adds an Acer model to the HDA codec > driver. It assumes that Jonathan's patch (posted here on 23 Feb 2006 > 11:18:26 +1030 (CST)) has already been applied, so it applies on top > of it. > > I have tested the patch with my mom's Acer (erased > /var/lib/alsa/asound.state, then cold-rebooted the computer), > everything seems to be working fine. > > The patch itself is much cleaner than the one attached to bug 1618. It > doesn't clutter the mixer with useless controls, and starts up with > settings more appropriate for an Acer. > > Also, please note the "(?)"'s next to CD and Beep controls. These > controls don't actually influence anything now, but I suspect they > would work after a few more GPIO commands are issued, so I've left > them there for now (read below). I prefer removing '(?)'. In case you are not sure whether these controls really work, you can add a comment in the source code or create a document. > Btw, this patch also fixes a few comment typos in patch_realtek.c and > changes one setting in test model (it seems like inicially copy-pasted > from Fujitsu model). Also, it adds lines muting NID 0x15 for Fujitsu > model on startup (Jonathan, you said it turned out not to be > problematic at all). > > Takashi, would you please commit this to upstream (along with > Jonathan's patch)? Sure, once I got patches for Jonathan, I'll apply yours. > Jonathan, how about your idea to add GPIO controls to the test model? > I think it would help testing. Hopefully, after these are added, I > could modify the Acer model in a way that CD and Beep controls would > become useful. Or, if playing with GPIO would seem useless, I could > simply remove those controls out of the mixer at all. > > Now a few notes/questions: > * is there any reason in defining ADC NIDs for every model separately? > They seem to be the same anyways, and not to get in anyones way. Or do > they? > * There seems to be a mixup between tab-indented and space-indented Basically tabs are better. They are mixed up just as a result of merge of many different patches. If you can fix to use tabs, please do it. > lines. It was like that at least in Fujitsu init verbs definition, and > now i've partially copied it to Acer... > * If the jack is called "Line In", should I leave it as "Line" in > mixer, or should I name it "Line In"? "Line" would be better since the OSS-emulation code uses this word to construct the mixer layer. > * What's your opinion about adding a model configuration line that > would only check the subvendor (and ignore the subdevice setting)? > There would be more chances to autodetect an Acer laptop then, but > OTOH, if one day there'll be an ALC-260 based Acer with a different > config, you'd risk to misdetect, or to regress in automatic Acer > detectlion by removing that line... You can set zero to subdevice to compare only subvendor. Thanks for your work! Takashi ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642