Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05577C3A5A5 for ; Thu, 5 Sep 2019 05:48:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77A772184B for ; Thu, 5 Sep 2019 05:48:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NyvjCsa3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77A772184B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 574DB165D; Thu, 5 Sep 2019 07:47:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 574DB165D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1567662502; bh=hTMvkEBYDSyB6Gc9IheNM/BWKt3+dn+c6XE+WcQ+dhI=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NyvjCsa3jyp64TEmmihpGdO8NdtN4SsWchyEq97cfKkW/8WOXvEJbSkrV14SJ9b8g y1xmmaP1Xh4TY0YLybmuM94CVwP+d1ybpGCOpuKHY/ZrpGSqeRMAO1FSjdRqgL+Z0B UvaFM20ruSqsnRQZTd/+IPJxqyUOYBvD2ZHvYIVg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BAABEF803D1; Thu, 5 Sep 2019 07:47:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0A030F80448; Thu, 5 Sep 2019 07:47:30 +0200 (CEST) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CBD52F80227; Thu, 5 Sep 2019 07:47:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CBD52F80227 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A059BAFE2; Thu, 5 Sep 2019 05:47:24 +0000 (UTC) Date: Thu, 05 Sep 2019 07:47:24 +0200 Message-ID: From: Takashi Iwai To: Pawel Harlozinski In-Reply-To: <20190905053302.9262-1-pawel.harlozinski@linux.intel.com> References: <20190905053302.9262-1-pawel.harlozinski@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: cezary.rojewski@intel.com, patch@alsa-project.org, alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com, broonie@kernel.org Subject: Re: [alsa-devel] [RFC PATCH 1/3] ALSA:hda: Simplify and clear calculating SDxFMT X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 05 Sep 2019 07:32:59 +0200, Pawel Harlozinski wrote: > > Set SDxFMT based only on given format, due to maxbps not always being set. > Split cases for formats 20,24,32 bits. > For format SNDRV_PCM_FORMAT_FLOAT_LE width is equal 32 so it will end up > with same mask. This function corresponds to snd_hdac_query_supported_pcm(), so this patch breaks. Basically the cases of 20 and 24 are superfluous and can be dropped. It's there just to be sure. Takashi > > Signed-off-by: Pawel Harlozinski > --- > sound/hda/hdac_device.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c > index b26cc93e7e10..add758e11b85 100644 > --- a/sound/hda/hdac_device.c > +++ b/sound/hda/hdac_device.c > @@ -759,14 +759,13 @@ unsigned int snd_hdac_calc_stream_format(unsigned int rate, > val |= AC_FMT_BITS_16; > break; > case 20: > + val |= AC_FMT_BITS_20; > + break; > case 24: > + val |= AC_FMT_BITS_24; > + break; > case 32: > - if (maxbps >= 32 || format == SNDRV_PCM_FORMAT_FLOAT_LE) > - val |= AC_FMT_BITS_32; > - else if (maxbps >= 24) > - val |= AC_FMT_BITS_24; > - else > - val |= AC_FMT_BITS_20; > + val |= AC_FMT_BITS_32; > break; > default: > return 0; > -- > 2.17.1 > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel