From: Takashi Iwai Subject: Re: [PATCH 2/3] sound: enable interrupt after dma buffer initialization Date: Tue, 11 Sep 2018 08:06:49 +0200 Message-ID: References: <20180910211718.200802-1-yuzhao@google.com> <20180910212150.202655-1-yuzhao@google.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180910212150.202655-1-yuzhao@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu Zhao Cc: Mark Brown , alsa-devel@alsa-project.org, Rakesh Ughreja , Vinod Koul , Jaroslav Kysela , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Mon, 10 Sep 2018 23:21:50 +0200, Yu Zhao wrote: > > In snd_hdac_bus_init_chip(), we enable interrupt before > snd_hdac_bus_init_cmd_io() initializing dma buffers. If irq has > been acquired and irq handler uses the dma buffer, kernel may crash > when interrupt comes in. > > Fix the problem by postponing enabling irq after dma buffer > initialization. And warn once on null dma buffer pointer during the > initialization. > > Signed-off-by: Yu Zhao Looks good to me. Reviewed-by: Takashi Iwai BTW, the reason why this hasn't been hit on the legacy HD-audio driver is that we allocate usually with MSI, so the irq is isolated. Any reason that Intel SKL driver doesn't use MST? thanks, Takashi