From: Takashi Iwai Subject: Re: [PATCH 1/2] plugin:dshare: wrong state reporting Date: Wed, 05 Apr 2017 21:40:11 +0200 Message-ID: References: <1491287392-11251-1-git-send-email-sutar.mounesh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 394552671C5 for ; Wed, 5 Apr 2017 21:40:12 +0200 (CEST) In-Reply-To: <1491287392-11251-1-git-send-email-sutar.mounesh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: sutar.mounesh@gmail.com Cc: alsa-devel@alsa-project.org, Andreas Pape , mounesh_sutar@mentor.com List-Id: alsa-devel@alsa-project.org On Tue, 04 Apr 2017 08:29:52 +0200, sutar.mounesh@gmail.com wrote: > > From: Andreas Pape > > If plugin dshare detects underrun, it reports this to the user > via return value -EPIPE and setting dshare state to 'xrun' which is correct. > But, if user after this wants to check the stream state, it is misleadingly > reported as 'running' instead of 'xrun'. > With this behavior aplay e.g. will not do a proper underrun handling > (restarting stream) but terminates streaming. > This is due to plugin dshare always returns state of the slave pcm, > in pcm_ops->state() which is not correct. > > Signed-off-by: Andreas Pape > Signed-off-by: Mounesh Sutar Applied now. Thanks. Takashi > > diff --git a/src/pcm/pcm_dshare.c b/src/pcm/pcm_dshare.c > index 331f799..4c57fb4 100644 > --- a/src/pcm/pcm_dshare.c > +++ b/src/pcm/pcm_dshare.c > @@ -244,7 +244,7 @@ static int snd_pcm_dshare_status(snd_pcm_t *pcm, snd_pcm_status_t * status) > default: > break; > } > - > + status->state = snd_pcm_state(pcm); > status->trigger_tstamp = dshare->trigger_tstamp; > status->avail = snd_pcm_mmap_playback_avail(pcm); > status->avail_max = status->avail > dshare->avail_max ? status->avail : dshare->avail_max; > -- > 2.7.4 >