From: Takashi Iwai Subject: Re: [PATCH] pcm_dshare: Do not discard slave reported delay in status result. Date: Thu, 17 Nov 2016 15:21:27 +0100 Message-ID: References: <5810BDF9.1020204@IEE.org> <5819F566.2000404@IEE.org> <581A23B9.3050609@IEE.org> <67297312-c4f9-e47d-4b58-893ddb55d2c8@IEE.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 9C2D3266968 for ; Thu, 17 Nov 2016 15:21:29 +0100 (CET) In-Reply-To: <67297312-c4f9-e47d-4b58-893ddb55d2c8@IEE.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Alan Young Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, 17 Nov 2016 15:18:04 +0100, Alan Young wrote: > > On 17/11/16 10:31, Takashi Iwai wrote: > > On Thu, 17 Nov 2016 09:20:16 +0100, > > Alan Young wrote: > >> snd_pcm_dshare_status() gets the underlying status from the slave PCM. > >> This may contain a delay value that includes elements such as codec and > >> other transfer delays. Use this as the base for the returned delay > >> value, adjusted for any frames buffered locally (within the dshare > >> plugin). > >> > >> Note: snd_pcm_dshare_delay() is not updated. > > Thanks for the patch, but it doesn't look like a proper patch to be > > applied to the latest git tree. I guess you created a patch on top of > > the modified tree. > > > > Please rebase and resubmit. > > > > Also, don't forget to add your sign-off. We prefer having it in > > alsa-lib code like the kernel code (although it's not strictly > > needed). > > I can add a signoff but first I need to understand what is wrong with > the patch. > > I did a git pull of master from > git://git.alsa-project.org/alsa-lib.git, committed my patch on top > (previous commit a668a94238d: "mixer: Don't install smixer modules > unless python is enabled") and did a git format-patch to generate the > supplied patch. What did I do wrong? Try a clean alsa-lib.git checkout and apply your patch manually there. Then you'll see what I meant. Takashi