From: Takashi Iwai Subject: Re: [PATCH 2/3] ALSA - hda: Add support for link audio time reporting Date: Fri, 15 Jul 2016 07:39:17 +0200 Message-ID: References: <1468232009-14130-3-git-send-email-vinod.koul@intel.com> <201607111916.R5HdrB76%fengguang.wu@intel.com> <20160715043721.GL9681@localhost> <20160715051906.GM9681@localhost> <20160715053910.GN9681@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A0F7C265873 for ; Fri, 15 Jul 2016 07:39:18 +0200 (CEST) In-Reply-To: <20160715053910.GN9681@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, Hardik T Shah , Guneshwor Singh , liam.r.girdwood@linux.intel.com, broonie@kernel.org, kbuild-all@01.org List-Id: alsa-devel@alsa-project.org On Fri, 15 Jul 2016 07:39:10 +0200, Vinod Koul wrote: > > On Fri, Jul 15, 2016 at 07:17:14AM +0200, Takashi Iwai wrote: > > On Fri, 15 Jul 2016 07:19:06 +0200, > > Vinod Koul wrote: > > > > > > >> sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory > > > > > > compilation terminated. > > > > > > > > > > Okay i think I need to move this bit into the intel code. > > > > > > > > > > Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add > > > > > this now. Are you okay with that? > > > > > > > > Better to have an explicit ifdef CONFIG_X86 around it. It's not only > > > > for x86. > > > > > > Need it around the whole of the timestamp code as well then.. > > > > Yes. But why TSC is mandatory? There is no explanation in your > > patch. > > HW reports ART values and we need to convert these to TSC. > > The callflow is that the azx_get_crosststamp is called which invokes > get_device_system_crosststamp() and calls azx_get_sync_time callback. > > So dependency is around convert_art_to_tsc() which is x86 API. How is defined in the spec? I wonder it because HD-audio spec itself is usually CPU-neutral. Takashi