From: Takashi Iwai Subject: Re: [PATCH v3 4/6] core: add API header and driver header files Date: Tue, 13 Dec 2011 08:03:17 +0100 Message-ID: References: <1321951920-4363-1-git-send-email-vinod.koul@linux.intel.com> <1323070791-12620-5-git-send-email-vinod.koul@linux.intel.com> <20111213061134.GA7148@opensource.wolfsonmicro.com> <1323757890.1641.39.camel@vkoul-udesk3> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D2F1F103AB4 for ; Tue, 13 Dec 2011 08:03:17 +0100 (CET) In-Reply-To: <1323757890.1641.39.camel@vkoul-udesk3> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, Mark Brown , lrg@ti.com, Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org At Tue, 13 Dec 2011 12:01:30 +0530, Vinod Koul wrote: > > On Tue, 2011-12-13 at 14:11 +0800, Mark Brown wrote: > > On Mon, Dec 05, 2011 at 01:09:49PM +0530, Vinod Koul wrote: > > > > > +static inline void snd_compr_fragment_elapsed(struct snd_compr_stream *stream) > > > +{ > > > + wake_up(&stream->runtime->sleep); > > > +} > > > > You need to include sched.h for this. > Hmmm, I have a different POV for these. > I would like driver to include the sched.h here and this not be in > header file. In general, a header file should be self-contained as much as possible. Since you are calling it in an inline function, it'd be more consistent to include sched.h in it. Takashi