From: Takashi Iwai Subject: Re: Fix section mismatch in wm8995.c Date: Tue, 11 Jan 2011 18:48:30 +0100 Message-ID: References: <20110111171013.GK6541@sirena.org.uk> <20110111172839.GE13429@opensource.wolfsonmicro.com> <20110111173349.GF13429@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id AB1AD10386B for ; Tue, 11 Jan 2011 18:48:30 +0100 (CET) In-Reply-To: <20110111173349.GF13429@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Dimitris Papastamos , alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org At Tue, 11 Jan 2011 17:33:49 +0000, Mark Brown wrote: > > On Tue, Jan 11, 2011 at 06:32:32PM +0100, Takashi Iwai wrote: > > Mark Brown wrote: > > > > The array is ~25k so it's not a completely trivial amount of memory, > > > unfortunately. > > > Hm. But, it's same for (some) other codecs, no? > > If we do annotate something, we should mark all these at once. > > In principle, though since it requires per driver checking for > references and so on it's not as simple as just going through and > annotating. It's partly tied in with the cache stuff, things that are > fully using that can be converted over easily. And of course many of > the devices have much smaller register maps so it's much less of an > issue. IMO, such a data should be uniquely handled -- either init-only or not. Through a quick look, snd_soc_cache_sync() may still refer to reg_cache_default. So, it's still risky to blindly set __devinitconst. (Yeah, I know it's not used right now, though ;) That is, the data that shall be deleted shouldn't be kept in a structure that might be referred later from other places. thanks, Takashi