From: Takashi Iwai Subject: Re: device_create_drvdata missing on older kernels Date: Wed, 30 Jul 2008 12:31:47 +0200 Message-ID: References: <200807301500.34579.linux@audioscience.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id AA64724960 for ; Wed, 30 Jul 2008 12:31:47 +0200 (CEST) In-Reply-To: <200807301500.34579.linux@audioscience.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Eliot Blennerhassett Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 30 Jul 2008 15:00:34 +1200, Eliot Blennerhassett wrote: > > I could not compile current git. (Error on acore/init.c) > > Adding this to adriver.h fixed it for me. I'm not sure if this is the correct > general fix? > > #ifndef CONFIG_SND_HAS_DEVICE_CREATE_DRVDATA > #define device_create_drvdata(c,d,m,p,s,n) device_create((c),(d),(m),(s),(n)) > #endif It works right now for vanilla, but not for linux-next, unfortunately. device_create_drvdata() is gone again in the next kernel. Long live the function. Could you check it's fixed on the snapshot tarball? http://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/ Takashi