From: Takashi Iwai Subject: Re: Building for 2.4 kernel.. Date: Mon, 21 Jan 2008 14:35:42 +0100 Message-ID: References: <20080121002845.GA6526@bagatelle.tuells.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 2ADA0244E3 for ; Mon, 21 Jan 2008 14:35:43 +0100 (CET) In-Reply-To: <20080121002845.GA6526@bagatelle.tuells.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: marcus hall Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sun, 20 Jan 2008 17:28:45 -0700, marcus hall wrote: > > I support a product that is running the 2.4.18 linux kernel, and was trying > to install alsa-driver-1.0.15, and ran into a problem. > > The alsa-kernel/pci/cs5535audio/cs5535audio_pm.c contains: > > if (pci_save_state(pci)) { > ... > > and a similar line for pci_restore_state(). > > But, in include/adriver.h, pci_save_state is #defined to > snd_pci_compat_save_state, which is declared to return void, so the > compiler complains that the void return isn't being ignored. > > Now, pci_save_state() appears to be supposed to return status, although > in the 2.4 kernel at least, it returns a constant 0. > > Nevertheless, to get things to work, I changed snd_pci_compat_save_state(), > snd_pci_orig_save_state(), and the corresponding restore functions to return > an int with the following patch. (The other obvious solution would be to > remove the test in cs5535audio_pm.c, but pci_save_state() is *supposed* > to return an int...) Thanks, applied to HG tree. Takashi