From: Takashi Iwai Subject: Re: hdsp driver broken for Multiface II Rev 35 Date: Wed, 16 Jan 2008 16:00:23 +0100 Message-ID: References: <20080114022142.51d6ae44@pluto.noname> <20080115204215.2dfb6544@pluto.noname> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx1.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id A3C2224469 for ; Wed, 16 Jan 2008 16:00:23 +0100 (CET) In-Reply-To: <20080115204215.2dfb6544@pluto.noname> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Andreas Degert Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 15 Jan 2008 20:42:15 +0100, Andreas Degert wrote: > > On Mon, 14 Jan 2008 12:00:10 +0100 > Takashi Iwai wrote: > > [...] > > > > > > static int hdsp_playback_to_output_key (struct hdsp *hdsp, int in, > > > int out) { > > > switch (hdsp->io_type) { > > > case Multiface: > > > case Digiface: > > > default: > > > if (hdsp->firmware_rev == 0xa) > > > return (64 * out) + (32 + (in)); > > > else > > > return (52 * out) + (26 + (in)); > > > case H9632: > > > return (32 * out) + (16 + (in)); > > > case H9652: > > > return (52 * out) + (26 + (in)); > > > } > > > } > > > > This looks OK. Could you prepare a patch (with a proper changelog and > > your sing-off)? > > ok, here it is: > > hdsp: make Multiface II work again > > This device has io_type == 1 (Multiface) and firmware_rev > 0xa > (fixes regression from changeset 5326) > > Signed-off-by: Andreas Degert Applied to HG tree now. Thanks! Takashi