Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25BB9C433EF for ; Mon, 9 May 2022 08:54:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 443AE1918; Mon, 9 May 2022 10:53:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 443AE1918 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652086482; bh=+EEAmDVcmIgjTm/dYTCx2Uy77YgF5GkRkEjo/tB7kzs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a79EC5d1zgp+w+JF8Dvfo43K5lTdLes8GnY6OXGa9OvPCUFRZ0zl7gi+ChMaxYnS1 +UxvVLHauNZ0RZq7d5nXLkDcgmlSeYr/m7/VlUAgSseeoC9hFixbUYOLIyUKr+Dlha NWyJWNxWDg8YUdAldQL2kwNmHh5gfWVQHGyxT5lM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 88437F80237; Mon, 9 May 2022 10:53:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CB88CF8047B; Mon, 9 May 2022 10:53:37 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61B0BF802E3 for ; Mon, 9 May 2022 10:53:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61B0BF802E3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="A34L+qWn"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UKYq4/y/" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9125E21B3D; Mon, 9 May 2022 08:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652086413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dfcvUUdqksgvYc8rVDLHC5DOBo/kU2XO+VX1eeG4aV8=; b=A34L+qWnS4KTuUIJIOdn/Oy0lRYM0k4tu6TprpUGGmO4q2IG6PgANqhT26b8ERa1UPxmL3 +i1ltyuQDR6b3JXdcEzOXVh1KYWhR2Zwt+tTJHHP3RNo/us6IFdzvOCkW7gcDMpTyzgCvx xJwG93EwlvMl01wRmSewhq2A5QaBHXU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652086413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dfcvUUdqksgvYc8rVDLHC5DOBo/kU2XO+VX1eeG4aV8=; b=UKYq4/y/oVRFARjOiTG0UlZFJ7CNosy5fO4czqcNJLtcbGcYGz4OJwlbgEGhzVQm3iPfhB Fx+12pZoeT2rmkDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 79C5C2C141; Mon, 9 May 2022 08:53:33 +0000 (UTC) Date: Mon, 09 May 2022 10:53:33 +0200 Message-ID: From: Takashi Iwai To: Niklas Schnelle Subject: Re: [RFC v2 31/39] sound: add HAS_IOPORT dependencies In-Reply-To: <20220429135108.2781579-57-schnelle@linux.ibm.com> References: <20220429135108.2781579-1-schnelle@linux.ibm.com> <20220429135108.2781579-57-schnelle@linux.ibm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-arch@vger.kernel.org, Arnd Bergmann , "moderated list:SOUND" , Arnd Bergmann , Greg Kroah-Hartman , Takashi Iwai , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 29 Apr 2022 15:50:54 +0200, Niklas Schnelle wrote: > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. For SND_OPL3_LIB this adds its first > dependency so drivers currently selecting it unconditionally need to > depend on it instead. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle > --- > sound/drivers/Kconfig | 5 ++++ > sound/isa/Kconfig | 44 ++++++++++++++--------------- > sound/pci/Kconfig | 64 +++++++++++++++++++++++++++++-------------- > 3 files changed, 70 insertions(+), 43 deletions(-) > > diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig > index ca4cdf666f82..4d250e619786 100644 > --- a/sound/drivers/Kconfig > +++ b/sound/drivers/Kconfig > @@ -1,10 +1,12 @@ > # SPDX-License-Identifier: GPL-2.0-only > config SND_MPU401_UART > tristate > + depends on HAS_IOPORT > select SND_RAWMIDI > > config SND_OPL3_LIB > tristate > + depends on HAS_IOPPORT > select SND_TIMER > select SND_HWDEP > select SND_SEQ_DEVICE if SND_SEQUENCER != n Both of those are the items to be reverse-selected, so cannot fulfill the dependency with depends-on. That is, the items that select those should have the dependency on HAS_IOPORT instead. That is, a change like below: > --- a/sound/isa/Kconfig > +++ b/sound/isa/Kconfig > @@ -31,7 +31,7 @@ if SND_ISA > > config SND_ADLIB > tristate "AdLib FM card" > - select SND_OPL3_LIB > + depends on SND_OPL3_LIB ... won't work. CONFIG_SND_OPL3_LIB is not enabled by itself but only to be selected. thanks, Takashi