From: Takashi Iwai Subject: Re: [PATCH] ALSA: uapi: #include in asound.h Date: Mon, 01 Apr 2019 12:33:37 +0200 Message-ID: References: <20190329224854.38009-1-danielmentz@google.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2BBBEF8075C for ; Mon, 1 Apr 2019 12:33:38 +0200 (CEST) In-Reply-To: <20190329224854.38009-1-danielmentz@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Daniel Mentz Cc: etam@google.com, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Fri, 29 Mar 2019 23:48:54 +0100, Daniel Mentz wrote: > > The uapi header asound.h defines types based on struct timespec. We need > to #include to get access to the definition of this struct. > > Previously, we encountered the following error message when building > applications with a clang/bionic toolchain: > > kernel-headers/sound/asound.h:350:19: error: field has incomplete type 'struct timespec' > struct timespec trigger_tstamp; > ^ > > The absence of the time.h #include statement does not cause build errors > with glibc, because its version of stdlib.h indirectly includes time.h. > > Signed-off-by: Daniel Mentz Applied, thanks. Takashi