From: Takashi Iwai Subject: Re: [PATCH] ALSA: usb-audio: Fix parsing descriptor of UAC2 processing unit Date: Mon, 19 Mar 2018 16:45:29 +0100 Message-ID: References: <20180319061108.24178-1-k.marinushkin@gmail.com> <20180319074019.GA30688@kroah.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kirill Marinushkin Cc: Greg Kroah-Hartman , alsa-devel@alsa-project.org, Ruslan Bilovol , Mark Brown , Thomas Gleixner , Felipe Balbi , Philippe Ombredanne , Jaroslav Kysela , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Mon, 19 Mar 2018 08:47:49 +0100, Takashi Iwai wrote: > > On Mon, 19 Mar 2018 08:40:19 +0100, > Greg Kroah-Hartman wrote: > > > > On Mon, Mar 19, 2018 at 07:11:08AM +0100, Kirill Marinushkin wrote: > > > Currently, the offsets in the UAC2 processing unit descriptor are > > > calculated incorrectly. It causes an issue when connecting the device which > > > provides such a feature: > > > > > > ~~~~ > > > [84126.724420] usb 1-1.3.1: invalid Processing Unit descriptor (id 18) > > > ~~~~ > > > > > > After this patch is applied, the UAC2 processing unit inits w/o this error. > > > > > > Fixes: 5e1ddb481776 ("UAPI: (Scripted) Disintegrate include/linux/usb") > > > Signed-off-by: Kirill Marinushkin > > > Cc: Mark Brown > > > Cc: Jaroslav Kysela > > > Cc: Takashi Iwai > > > Cc: Thomas Gleixner > > > Cc: Felipe Balbi > > > Cc: Philippe Ombredanne > > > Cc: Greg Kroah-Hartman > > > Cc: Ruslan Bilovol > > > Cc: linux-kernel@vger.kernel.org > > > Cc: alsa-devel@alsa-project.org > > > --- > > > include/uapi/linux/usb/audio.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Cc: stable > > perhaps? > > Yes, it deserves. But I'd need to double-check the UAC2 > specification. It's interesting that such a basic thing hasn't hit > until now. Maybe just because it's a fairly minor feature. ... and the patch looks correct, after confirming the UAC2 spec. Now I applied it, with a minor correction of Fixes tag, which actually was introduced by 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0"), and adding Cc to stable. Thanks! Takashi