From: Takashi Iwai Subject: Re: [PATCH] ALSA - hda: hdmi check NULL pointer in hdmi_set_chmap Date: Mon, 18 Apr 2016 07:28:18 +0200 Message-ID: References: <1460942188-31274-1-git-send-email-libin.yang@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id E5BAB261ADB for ; Mon, 18 Apr 2016 07:28:19 +0200 (CEST) In-Reply-To: <1460942188-31274-1-git-send-email-libin.yang@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: libin.yang@linux.intel.com Cc: libin.yang@intel.com, mengdong.lin@intel.com, alsa-devel@alsa-project.org, liam.r.girdwood@intel.com List-Id: alsa-devel@alsa-project.org On Mon, 18 Apr 2016 03:16:28 +0200, libin.yang@linux.intel.com wrote: > > From: Libin Yang > > Make sure per_pin is not NULL before using it. > > Signed-off-by: Libin Yang Applied, thanks. Takashi > --- > sound/pci/hda/patch_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 4833c7b..c99289d 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -1858,6 +1858,8 @@ static void hdmi_set_chmap(struct hdac_device *hdac, int pcm_idx, > struct hdmi_spec *spec = codec->spec; > struct hdmi_spec_per_pin *per_pin = pcm_idx_to_pin(spec, pcm_idx); > > + if (!per_pin) > + return; > mutex_lock(&per_pin->lock); > per_pin->chmap_set = true; > memcpy(per_pin->chmap, chmap, ARRAY_SIZE(per_pin->chmap)); > -- > 1.9.1 >