From: Takashi Iwai Subject: Re: [PATCH] ALSA: echoaudio: Use standard C definitions of true and false Date: Mon, 10 Aug 2015 14:29:24 +0200 Message-ID: References: <1439208173-16501-1-git-send-email-broonie@kernel.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 437E42608BC for ; Mon, 10 Aug 2015 14:29:24 +0200 (CEST) In-Reply-To: <1439208173-16501-1-git-send-email-broonie@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 10 Aug 2015 14:02:53 +0200, Mark Brown wrote: > > The echoaudio locally defines TRUE and FALSE. Not only is this > redundant given that C now has a boolean type it results in lots of > warnings as other headers also define these macros, causing duplicate > definitions. Fix this by removing the local defines and converting all > local users to use the standard C true and false instead, simply > removing the macros is less safe due to implicit inclusion of the other > definitons. > > Signed-off-by: Mark Brown Well, there were leftover FALSE's that broke the compilation. I applied the patch with the manual fix now. thanks, Takashi