From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] rme96 add stream synchronization and PM
	support
Date: Wed, 14 Aug 2013 17:06:33 +0200
Message-ID: <s5hd2pgs45i.wl%tiwai@suse.de>
References: <51FF9C55.80701@t-online.de> <51FFA643.7060504@ladisch.de>
 <52013579.7020304@t-online.de> <s5h4nb2asg5.wl%tiwai@suse.de>
 <52037864.9000205@t-online.de> <s5h61vacb25.wl%tiwai@suse.de>
 <520A0B2C.7060500@t-online.de> <s5hy585x4e3.wl%tiwai@suse.de>
 <520AA125.5010803@t-online.de>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 7BF5A2654D3
 for <alsa-devel@alsa-project.org>; Wed, 14 Aug 2013 17:04:39 +0200 (CEST)
In-Reply-To: <520AA125.5010803@t-online.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Knut Petersen <Knut_Petersen@t-online.de>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Tue, 13 Aug 2013 23:12:05 +0200,
Knut Petersen wrote:
> 
> @@ -2390,6 +2486,21 @@ snd_rme96_probe(struct pci_dev *pci,
>  		return err;
>  	}
>  	
> +#ifdef CONFIG_PM
> +	rme96->playback_suspend_buffer = vmalloc(RME96_BUFFER_SIZE);
> +	if (!rme96->playback_suspend_buffer) {
> +		snd_printk(KERN_ERR
> +			   "Failed to allocate playback suspend buffer!\n");
> +		return -ENOMEM;

Call snd_card_free().  Otherwise leaking.

> +	}
> +	rme96->capture_suspend_buffer = vmalloc(RME96_BUFFER_SIZE);
> +	if (!rme96->capture_suspend_buffer) {
> +		snd_printk(KERN_ERR
> +			   "Failed to allocate capture suspend buffer!\n");
> +		return -ENOMEM;

Ditto.


The first patch looks OK, so applied it.
Please resubmit only the second patch with the fixes.


thanks,

Takashi