From: Takashi Iwai Subject: Re: [PATCH 1/1] Add USB audio quirk supporting Roland VG-99 advanced mode Date: Sun, 21 Oct 2012 12:13:15 +0200 Message-ID: References: <1350723664-7368-1-git-send-email-pete.leigh@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8DEC6265151 for ; Sun, 21 Oct 2012 12:13:15 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pete Leigh Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sun, 21 Oct 2012 10:34:57 +0100, Pete Leigh wrote: > > On 21 October 2012 09:40, Takashi Iwai wrote: > > > Could you give a bit more descriptive commit log? > > I see you put more in comments, but it'd be also good to have more > > information in the changelog. > > Ok, done I hope. Thanks, applied now. > Perhaps it's worth noting - I ran the patch checking script, and it > did not like the spaces after '&', nor line lengths, in a couple of > places in the patch, but I obeyed the conventions of the existing code > in the file rather than what the script said, and kept things as they > were. Hope that's ok. Don't worry about that. checkpatch.pl is just too picky. Takashi