From: Takashi Iwai Subject: Re: [alsa-plugins PATCH] pulse: Support 24-bit formats Date: Mon, 20 Aug 2012 11:30:45 +0200 Message-ID: References: <20120817204107.GV2424@foghorn.codeweavers.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 95D4D265DB9 for ; Mon, 20 Aug 2012 11:00:59 +0200 (CEST) In-Reply-To: <20120817204107.GV2424@foghorn.codeweavers.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel , Andrew Eikum List-Id: alsa-devel@alsa-project.org At Fri, 17 Aug 2012 15:41:07 -0500, Andrew Eikum wrote: > > These formats were introduced in PulseAudio 0.9.15. There aren't any > new formats supported since then, so this also brings the PulseAudio > plugin in sync with current PulseAudio. > > Signed-off-by: Andrew Eikum > --- > > There was a problem once before with a patch I submitted. This is > using format-patch and imap-send, so hopefully it goes through better > than it did before :) Well, unfortunately it's not a preferred form of the patch. The patch commit log must be embedded in the patch itself. That is, the text above including your sign-off must be in the git commit log, then generate the patch via git-format-patch or git show --pretty=email. In anyway, I applied your patch manually now. Please try the right way at the next time. thanks, Takashi > > pulse/pcm_pulse.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > [2 0001-pulse-Support-24-bit-formats.patch ] > diff --git a/pulse/pcm_pulse.c b/pulse/pcm_pulse.c > index e0fbd4c..24fd4da 100644 > --- a/pulse/pcm_pulse.c > +++ b/pulse/pcm_pulse.c > @@ -820,6 +820,26 @@ static int pulse_hw_params(snd_pcm_ioplug_t * io, > pcm->ss.format = PA_SAMPLE_S32BE; > break; > #endif > +#ifdef PA_SAMPLE_S24LE > + case SND_PCM_FORMAT_S24_3LE: > + pcm->ss.format = PA_SAMPLE_S24LE; > + break; > +#endif > +#ifdef PA_SAMPLE_S24BE > + case SND_PCM_FORMAT_S24_3BE: > + pcm->ss.format = PA_SAMPLE_S24BE; > + break; > +#endif > +#ifdef PA_SAMPLE_S24_32LE > + case SND_PCM_FORMAT_S24_LE: > + pcm->ss.format = PA_SAMPLE_S24_32LE; > + break; > +#endif > +#ifdef PA_SAMPLE_S24_32BE > + case SND_PCM_FORMAT_S24_BE: > + pcm->ss.format = PA_SAMPLE_S24_32BE; > + break; > +#endif > default: > SNDERR("PulseAudio: Unsupported format %s\n", > snd_pcm_format_name(io->format)); > [3 ] > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel