From: Takashi Iwai Subject: Re: [PATCH 2/2] ALSA: snd-usb: move calls to usb_set_interface Date: Fri, 13 Jul 2012 09:33:33 +0200 Message-ID: References: <1342099187-6978-1-git-send-email-zonque@gmail.com> <1342099187-6978-2-git-send-email-zonque@gmail.com> <4FFFBB5A.3000606@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 885EF104248 for ; Fri, 13 Jul 2012 09:33:34 +0200 (CEST) In-Reply-To: <4FFFBB5A.3000606@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Mack Cc: alsa-devel@alsa-project.org, clemens@ladisch.de, philipp@dreimann.net, joseph.salisbury@canonical.com List-Id: alsa-devel@alsa-project.org At Fri, 13 Jul 2012 08:08:26 +0200, Daniel Mack wrote: > > On 13.07.2012 07:58, Takashi Iwai wrote: > > At Thu, 12 Jul 2012 15:19:47 +0200, > > Daniel Mack wrote: > >> > >> The rework of the snd-usb endpoint logic moved the calls to > >> snd_usb_set_interface() into the snd_usb_endpoint implemenation. This > >> changed the order in which these calls are issued to the device, and > >> thereby caused regressions for some webcams. > >> > >> Fix this by moving the calls back to pcm.c for now to make it work again > >> and use snd_usb_endpoint_activate() to really tear down all remaining > >> URBs in the flight, consequently fixing another regression caused by USB > >> packets on the wire after altsetting 0 has been selected. > >> > >> Signed-off-by: Daniel Mack > >> Reported-and-tested-by: Philipp Dreimann > >> Reported-by: Joseph Salisbury > > > > Looks like the patch contains lots of coding-style issues. > > Could you fix what checkpatch.pl compains and resubmit? > > Oops, sorry. Was working on a different machine for this, hence I didn't > notice. Applied now. Thanks. Takashi