From: Takashi Iwai Subject: Re: [PATCH] ALSA: Add #ifdef CONFIG_PCI guard for snd_pci_quirk_lookup* functions Date: Mon, 30 Jan 2012 09:53:46 +0100 Message-ID: References: <1327903410.12540.3.camel@phoenix> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A6E4C2454E for ; Mon, 30 Jan 2012 09:53:48 +0100 (CET) In-Reply-To: <1327903410.12540.3.camel@phoenix> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Axel Lin Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Mon, 30 Jan 2012 14:03:30 +0800, Axel Lin wrote: > > This fixes below build warning when CONFIG_PCI is not set. > > CC sound/sound_core.o > In file included from sound/sound_core.c:15: > include/sound/core.h:454: warning: 'struct pci_dev' declared inside parameter list > include/sound/core.h:454: warning: its scope is only this definition or declaration, which is probably not what you want > > Signed-off-by: Axel Lin > --- > include/sound/core.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/sound/core.h b/include/sound/core.h > index 5ab255f..fce4b6f 100644 > --- a/include/sound/core.h > +++ b/include/sound/core.h > @@ -450,11 +450,13 @@ struct snd_pci_quirk { > {_SND_PCI_QUIRK_ID_MASK(vend, 0, 0), .value = (val)} > #endif > > +#ifdef CONFIG_PCI I'd begin the ifdef including the definition of struct snd_pci_quirk. Could you revise the patch? thanks, Takashi