From: Takashi Iwai Subject: Re: [PATCH] ASoC: Ensure we generate a driver name Date: Tue, 20 Sep 2011 15:32:48 +0200 Message-ID: References: <1316523514-21967-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20110920131804.GE2809@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C9584103A38 for ; Tue, 20 Sep 2011 15:32:48 +0200 (CEST) In-Reply-To: <20110920131804.GE2809@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Liam Girdwood List-Id: alsa-devel@alsa-project.org At Tue, 20 Sep 2011 14:18:05 +0100, Mark Brown wrote: > > On Tue, Sep 20, 2011 at 03:11:08PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > + snprintf(card->snd_card->driver, sizeof(card->snd_card->driver), > > > + "%s", card->driver_name ? card->driver_name : card->name); > > > + for (i = 0; i < ARRAY_SIZE(card->snd_card->driver); i++) { > > > Should check card->snd_card->driver[i] != 0 here, too. > > *sigh* This sort of issue is why I'd prefer to just squash specific > characters, especially given that we're just being random about what a > valid character is. Heh. Or just use a char *, such as char *p; ... for (p = card->snd_card->driver; *p; p++) { if (*p != '_' && *p != '-' && !isalnum(*p)) *p = '_'; } Takashi