From: Takashi Iwai Subject: Re: [PATCH 04/14] ASoC: Allow codecs to override register display Date: Fri, 01 Aug 2008 18:35:57 +0200 Message-ID: References: <1217328155-30158-3-git-send-email-broonie@opensource.wolfsonmicro.com> <1217328155-30158-4-git-send-email-broonie@opensource.wolfsonmicro.com> <9e4733910807311841v3ebe98f5i327606d7d793f832@mail.gmail.com> <20080801100003.GA16420@rakim.wolfsonmicro.main> <9e4733910808010750x69e71cd2i21eb0b448e11544a@mail.gmail.com> <20080801153538.GA11735@sirena.org.uk> <9e4733910808010913x46a4f57fm316b013984ac6b1c@mail.gmail.com> <20080801161613.GA2076@rakim.wolfsonmicro.main> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 9314724465 for ; Fri, 1 Aug 2008 18:35:59 +0200 (CEST) In-Reply-To: <20080801161613.GA2076@rakim.wolfsonmicro.main> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Fri, 1 Aug 2008 17:16:13 +0100, Mark Brown wrote: > > On Fri, Aug 01, 2008 at 12:13:52PM -0400, Jon Smirl wrote: > > > Allow external register display to suppress sparse registers > > As I said when you originally proposed this I'm really not happy about > changing to that interface. > > Adding explicit information about registers to skip and having this > function use it would be useful but munging it in makes the register > display function non-reusable and means that other parts of ASoC will be > unable to use the information about the void registers should they have > a use for it. Hm, is display_register already used in asoc tree by any drivers? If so, then it's a step backward, and I understand your statement. OTOH, showing lots of meaningless registers is bad, too. Looking back soc-core.c again, the primary problem is that codec_reg_show() assumes that the continuous register table beginning from 0. It'd be much easier if the driver provides a complete show method by itself for non-standard cases, e.g. sparse registers (i.e. just pass buf and let fill the whole page). Takashi