From: Takashi Iwai Subject: Re: Re: Ready Developer Date: Fri, 13 Sep 2002 18:16:00 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: multipart/mixed; boundary="Multipart_Fri_Sep_13_18:16:00_2002-1" Return-path: Received: from Cantor.suse.de (ns.suse.de [213.95.15.193]) by alsa.alsa-project.org (8.9.3/8.9.3/SuSE Linux 8.9.3-0.1) with ESMTP id SAA23260 for ; Fri, 13 Sep 2002 18:16:02 +0200 In-Reply-To: Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Tim Goetze Cc: Jaroslav Kysela , ALSA development List-Id: alsa-devel@alsa-project.org --Multipart_Fri_Sep_13_18:16:00_2002-1 Content-Type: text/plain; charset=US-ASCII At Fri, 13 Sep 2002 18:00:17 +0200 (CEST), Tim Goetze wrote: > > Takashi Iwai wrote: > > >At Fri, 13 Sep 2002 17:23:14 +0200 (CEST), > >Tim Goetze wrote: > >> > >> Takashi Iwai wrote: > >> > >> >At Fri, 13 Sep 2002 13:37:05 +0200 (CEST), > >> >Tim Goetze wrote: > >> >> > >> >> - get rid of nasty clicks on open/start/stop/close of pcms. > >> > > >> >which driver? ice1712? > >> > >> yes, m-man audiophile. the clicks are perceptible even if all > >> volumes are set to 0. > > > >i hoped that it be intel8x0 (it was fixed recently :) > > > >well, could you check whether this happen on plug layer or even on hw? > > using hw. from what jaroslav says, it seems the DA converter on the > audiophile is to blame. the AD stream looks ok, it's all zeroes right > from the start. > > the click actually happens when preparing the device, starting is ok. hmm, does the attached path cure? Takashi --Multipart_Fri_Sep_13_18:16:00_2002-1 Content-Type: application/octet-stream Content-Disposition: attachment; filename="ap-click.dif" Content-Transfer-Encoding: 7bit Index: alsa-kernel/pci/ice1712.c =================================================================== RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/ice1712.c,v retrieving revision 1.32 diff -u -r1.32 ice1712.c --- alsa-kernel/pci/ice1712.c 6 Sep 2002 15:05:20 -0000 1.32 +++ alsa-kernel/pci/ice1712.c 13 Sep 2002 16:14:15 -0000 @@ -1186,7 +1186,7 @@ { unsigned long flags; unsigned int rate; - unsigned char val, tmp; + unsigned char val, tmp, tmp2; spin_lock_irqsave(&ice->reg_lock, flags); if (inb(ICEMT(ice, PLAYBACK_CONTROL)) & (ICE1712_CAPTURE_START_SHADOW| @@ -1224,17 +1224,24 @@ case ICE1712_SUBDEVICE_DELTA44: case ICE1712_SUBDEVICE_AUDIOPHILE: spin_unlock_irqrestore(&ice->reg_lock, flags); - snd_ice1712_ak4524_reset(ice, 1); down(&ice->gpio_mutex); tmp = snd_ice1712_read(ice, ICE1712_IREG_GPIO_DATA); - if (val == 15 || val == 11 || val == 7) { - tmp |= ICE1712_DELTA_DFS; - } else { - tmp &= ~ICE1712_DELTA_DFS; - } - snd_ice1712_write(ice, ICE1712_IREG_GPIO_DATA, tmp); up(&ice->gpio_mutex); - snd_ice1712_ak4524_reset(ice, 0); + tmp2 &= ~ICE1712_DELTA_DFS; + if (val == 15 || val == 11 || val == 7) + tmp2 |= ICE1712_DELTA_DFS; + if (tmp != tmp2) { + snd_ice1712_ak4524_reset(ice, 1); + down(&ice->gpio_mutex); + tmp = snd_ice1712_read(ice, ICE1712_IREG_GPIO_DATA); + if (val == 15 || val == 11 || val == 7) + tmp |= ICE1712_DELTA_DFS; + else + tmp &= ~ICE1712_DELTA_DFS; + snd_ice1712_write(ice, ICE1712_IREG_GPIO_DATA, tmp); + up(&ice->gpio_mutex); + snd_ice1712_ak4524_reset(ice, 0); + } return; } __end: --Multipart_Fri_Sep_13_18:16:00_2002-1-- ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf