Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2316C433E1 for ; Thu, 27 Aug 2020 07:00:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53AC922BEA for ; Thu, 27 Aug 2020 07:00:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="f5t16tGG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53AC922BEA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C29C017C8; Thu, 27 Aug 2020 08:59:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C29C017C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598511599; bh=u56HHwey9KpECQSbXboTtHYMokwH1EVtQoZW7h7W4kA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=f5t16tGGddeAMUvoY/zeweYu+14shcsh7xv/8pyvHUv9zfQSu1FRF59dAHnNycIRb QM+dP5SFGelaoTHYQUHZd/5UKdNwO54tJTB+onje9pIrn7oL9xQmgFk3kuKtFu8+Jj ZFxcKq/3nE59CxV4Z3Yho4p3hSCCFxxKvcIB7Xmw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 50163F80143; Thu, 27 Aug 2020 08:59:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CC079F8016F; Thu, 27 Aug 2020 08:59:07 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BB38BF80085 for ; Thu, 27 Aug 2020 08:58:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BB38BF80085 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0E592B6BF; Thu, 27 Aug 2020 06:59:26 +0000 (UTC) Date: Thu, 27 Aug 2020 08:58:54 +0200 Message-ID: From: Takashi Iwai To: Harsha Priya Subject: Re: [PATCH] ALSA: Realtek: Early Forbid of runtime PM In-Reply-To: <1598505643-30347-1-git-send-email-harshapriya.n@intel.com> References: <1598505643-30347-1-git-send-email-harshapriya.n@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Emmanuel Jillela , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 27 Aug 2020 07:20:43 +0200, Harsha Priya wrote: > > For Realtek codecs, pm_runtime_forbid() is called in the probe function > after the build_controls(). In a stress test, occasionally the runtime > PM calls are invoked before controls are built. This causes the codec to be > runtime suspended before probe completes. Because of this, not all > controls are enumerated correctly and audio does not work until > system is rebooted. > > This patch calls pm_runtime_forbid() early to fix the issue. > Multiple stress tests of 2000+ cycles has been done to test the fix. > > Signed-off-by: Harsha Priya > Signed-off-by: Emmanuel Jillela > Reviewed-by: Kailang Yang The behavior shouldn't be specific to that model, also not to codec vendors, but it's rather a generic problem, so it's no right place to correct, I suppose. Can we simply call pm_runtime_forbid() at creating a codec object like below? thanks, Takashi --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1000,6 +1000,9 @@ int snd_hda_codec_device_new(struct hda_bus *bus, struct snd_card *card, if (err < 0) goto error; + /* PM runtime needs to be enabled later after binding codec */ + pm_runtime_forbid(&codec->core.dev); + return 0; error: