Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB34AC10DCE for ; Mon, 23 Mar 2020 20:26:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66DD82073E for ; Mon, 23 Mar 2020 20:26:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="n/K6c1sY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66DD82073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B82B711C; Mon, 23 Mar 2020 21:25:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B82B711C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584995186; bh=Gq03MQ9iOF7Wjq8UOA0cn/YqRfby2Clw8DqO4TowKUI=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=n/K6c1sYnS+nZPxUauYKH14aZyVYkXNje3qotdsIRNGpMOtrIOT4HIZX9KYKl5PhG BmCJ2atNcEmnYReLjefZ1w1ZzBSLBbsXQsNj/vlBmMkybq7qaCcK++d7IadNTjaSRi 8aMVdw2ms+JNshyFsyTo+Q+ByqeAY+/DcJSxps8E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 47D77F80095; Mon, 23 Mar 2020 21:25:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1C12EF80158; Mon, 23 Mar 2020 21:25:34 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6BB0CF80095 for ; Mon, 23 Mar 2020 21:25:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6BB0CF80095 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A6B62AFB5 for ; Mon, 23 Mar 2020 20:25:27 +0000 (UTC) Date: Mon, 23 Mar 2020 21:25:27 +0100 Message-ID: From: Takashi Iwai To: alsa-devel@alsa-project.org Subject: Re: [PATCH 2/2] ALSA: usb-audio: Avoid shoving a new stream into already registered device In-Reply-To: <20200323170643.19181-2-tiwai@suse.de> References: <20200323170643.19181-1-tiwai@suse.de> <20200323170643.19181-2-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 23 Mar 2020 18:06:43 +0100, Takashi Iwai wrote: > > USB-audio driver registers the card and its devices at each probe of > USB interface, while trying to append a USB substream into the empty > PCM stream slot. This works for most cases where the all PCM streams > are declared in the single interface description. However, when the > device provides multiple individual interfaces, this may up with > pushing a new stream into the existing snd_pcm object that has been > already registered. From the driver perspective, it's OK, but it > doesn't work for PulseAudio and others because they manage in the card > registration level, hence they'll miss this new device creation. > > This patch tries to warn such a too-late-appended stream, and also > tries to put rather into a new snd_pcm object. > > If we get a report from a user about this, we may add it to an entry > for snd_usb_registration_quirk(). > > Signed-off-by: Takashi Iwai Let's scratch this. It's better to be put together with a generic module option that allows specifying the delayed registration for the given device, and show the warning at the time of snd_card_register() call instead. Will respin the improved version later. Takashi