From: Takashi Iwai Subject: Re: [PATCH] ASoC: codec: hdac_hdmi: no checking monitor in hw_params Date: Tue, 07 May 2019 10:42:45 +0200 Message-ID: References: <1557210791-20332-1-git-send-email-libin.yang@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A1CEEF807B5 for ; Tue, 7 May 2019 10:42:46 +0200 (CEST) In-Reply-To: <1557210791-20332-1-git-send-email-libin.yang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: libin.yang@intel.com Cc: hui.wang@canonical.com, alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com List-Id: alsa-devel@alsa-project.org On Tue, 07 May 2019 08:33:11 +0200, libin.yang@intel.com wrote: > > From: Libin Yang > > Some userspace apps, like pulseaudio, may call open, hw_params, > prepare to judge whether the pcm is ready or not. Current hdac_hdmi > will return -ENODEV if monitor is not connected, which will cause > the apps believe the pcm is not ready. Actually PCM for hdmi is ready, > even the monitor is not connected. > > This patch removes the check of monitor presence in hw_params, just like > what the legacy HD-Audio driver does. > > Signed-off-by: Libin Yang LTGM, Reviewed-by: Takashi Iwai thanks, Takashi