From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop
Date: Wed, 21 Nov 2018 23:23:54 +0100
Message-ID: <s5hefbeax39.wl-tiwai@suse.de>
References: <s5hlg5mbch9.wl-tiwai@suse.de>
        <1542822552-110314-1-git-send-email-gkumar@neverware.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1542822552-110314-1-git-send-email-gkumar@neverware.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Girija Kumar Kasinadhuni <gkumar@neverware.com>
Cc: alsa-devel@alsa-project.org, Hui Wang <hui.wang@canonical.com>, Jaroslav Kysela <perex@perex.cz>, Kailang Yang <kailang@realtek.com>, linux-kernel@vger.kernel.org
List-Id: alsa-devel@alsa-project.org

On Wed, 21 Nov 2018 18:49:11 +0100,
Girija Kumar Kasinadhuni wrote:
> 
> @@ -6486,6 +6491,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x82bf, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x82c0, "HP", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
> +	SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre X360 ", ALC295_FIXUP_HP_AUTO_MUTE),

So this adds a new entry with the very same ID as the previous entry.
This won't work, unfortunately.  The quirk is chosen only for the
first matching one.

For making it working, you'd need to add to the chain of the existing
quirk instead.

And this shows that the patch wasn't properly tested...  Please check
the actual behavior before submitting the final version.


thanks,

Takashi