From: Takashi Iwai Subject: Re: [PATCH 2/3] ALSA - hda: Add support for link audio time reporting Date: Fri, 15 Jul 2016 07:17:14 +0200 Message-ID: References: <1468232009-14130-3-git-send-email-vinod.koul@intel.com> <201607111916.R5HdrB76%fengguang.wu@intel.com> <20160715043721.GL9681@localhost> <20160715051906.GM9681@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 12E94265873 for ; Fri, 15 Jul 2016 07:17:16 +0200 (CEST) In-Reply-To: <20160715051906.GM9681@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, Hardik T Shah , Guneshwor Singh , liam.r.girdwood@linux.intel.com, broonie@kernel.org, kbuild-all@01.org List-Id: alsa-devel@alsa-project.org On Fri, 15 Jul 2016 07:19:06 +0200, Vinod Koul wrote: > > On Fri, Jul 15, 2016 at 07:00:41AM +0200, Takashi Iwai wrote: > > On Fri, 15 Jul 2016 06:37:21 +0200, > > Vinod Koul wrote: > > > > > > On Mon, Jul 11, 2016 at 07:43:25PM +0800, kbuild test robot wrote: > > > > Hi, > > > > > > > > [auto build test ERROR on sound/for-next] > > > > [also build test ERROR on v4.7-rc7 next-20160711] > > > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > > > > > url: https://github.com/0day-ci/linux/commits/Vinod-Koul/ALSA-hda-Add-support-for-link-audio-time-reporting/20160711-180949 > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > > > > config: arm-multi_v7_defconfig (attached as .config) > > > > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 > > > > reproduce: > > > > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > # save the attached .config to linux build tree > > > > make.cross ARCH=arm > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > >> sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory > > > > compilation terminated. > > > > > > Okay i think I need to move this bit into the intel code. > > > > > > Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add > > > this now. Are you okay with that? > > > > Better to have an explicit ifdef CONFIG_X86 around it. It's not only > > for x86. > > Need it around the whole of the timestamp code as well then.. Yes. But why TSC is mandatory? There is no explanation in your patch. > Yes the HDA controller is not x86 specfic, but the hda-intel should be, > right? No, the driver depends on PCI, but not on CPU. thanks, Takashi