From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - Update BCLK also at hotplug for i915 HSW/BDW Date: Tue, 26 Apr 2016 10:14:51 +0200 Message-ID: References: <1461657770-24778-1-git-send-email-tiwai@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 91F292604BE for ; Tue, 26 Apr 2016 10:14:51 +0200 (CEST) Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 44552ABA6 for ; Tue, 26 Apr 2016 08:14:49 +0000 (UTC) In-Reply-To: <1461657770-24778-1-git-send-email-tiwai@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, 26 Apr 2016 10:02:50 +0200, Takashi Iwai wrote: > > The recent bug report suggests that BCLK setup for i915 HSW/BDW needs > to be updated at each HDMI hotplug, not only at initialization and > resume. That is, we need to update HSW_EM4 and HSW_EM5 registers at > ELD notification, too. Otherwise the HDMI audio may be out of sync > and played in a wrong pitch. > > However, the HDA codec driver has no access to the controller > registers, and currently the code managing these registers is in > hda_intel.c, i.e. local to the controller driver. For allowing the > explicit BCLK update from the codec driver, as in this patch, the > former haswell_set_bclk() in hda_intel.c is moved to hdac_i915.c and > exposed as snd_hdac_i915_set_bclk(). This is called from both the HDA > controller driver and intel_pin_eld_notify() in HDMI codec driver. > > Along with this change, snd_hdac_get_display_clk() gets dropped as > it's no longer used. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91410 > Cc: # v4.5+ > Signed-off-by: Takashi Iwai Oops, this is an old patch. The latest one will be submitted soon. Sorry for the noise. Takashi