From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda_intel: add AZX_DCAPS_I915_POWERWELL for skl Date: Fri, 27 Mar 2015 09:19:28 +0100 Message-ID: References: <1427440204-49331-1-git-send-email-libin.yang@intel.com> <96A12704CE18D347B625EE2D4A099D19622F1C@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 0C24B260410 for ; Fri, 27 Mar 2015 09:19:29 +0100 (CET) In-Reply-To: <96A12704CE18D347B625EE2D4A099D19622F1C@SHSMSX103.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Yang, Libin" Cc: "alsa-devel@alsa-project.org" List-Id: alsa-devel@alsa-project.org At Fri, 27 Mar 2015 08:02:54 +0000, Yang, Libin wrote: > > Hi Takashi, > > > > > -----Original Message----- > > From: Takashi Iwai [mailto:tiwai@suse.de] > > Sent: Friday, March 27, 2015 3:57 PM > > To: Yang, Libin > > Cc: alsa-devel@alsa-project.org > > Subject: Re: [PATCH] ALSA: hda_intel: add > > AZX_DCAPS_I915_POWERWELL for skl > > > > At Fri, 27 Mar 2015 15:10:04 +0800, > > libin.yang@intel.com wrote: > > > > > > From: Libin Yang > > > > > > HDMI/DP codec on SKL is in the power well. > > > The power well must be turned on before probing the > > > HDMI/DP codec. > > > > > > Signed-off-by: Libin Yang > > > > So, was the previous question clarified? > > Yes, I have confirmed with our silicon team. > > > > > This certainly sucks. It means that the powerwell is on even you > > don't use the HDMI/DP at all. If this is intended as a temporarily > > workaround, it should be mentioned so. Please give more comments > > and > > backgrounds. > > Yes, as this is added in the skl audio controller, even there is no HDMI/DP > codec, we should also add this flag. Otherwise the HDMI/DP codec > may not be detected correctly. But it's possible to do it only at probing, not permanently. If so, we'll have another patch in future. Please write more information in the changelog and resubmit. Takashi