From: Takashi Iwai Subject: Re: [PATCH] drm/i915, HD-audio: Don't continue probing when nomodeset is given Date: Fri, 13 Jun 2014 18:09:43 +0200 Message-ID: References: <1402674962-18189-1-git-send-email-tiwai@suse.de> <20140613160705.GT5821@phenom.ffwll.local> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140613160705.GT5821@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: alsa-devel@alsa-project.org, Mengdong Lin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: alsa-devel@alsa-project.org At Fri, 13 Jun 2014 18:07:06 +0200, Daniel Vetter wrote: > > On Fri, Jun 13, 2014 at 05:56:02PM +0200, Takashi Iwai wrote: > > When a machine is booted with nomodeset option, i915 driver skips the > > whole initialization. Meanwhile, HD-audio tries to bind wth i915 just > > by request_symbol() without knowing that the initialization was > > skipped, and eventually it hits WARN_ON() in i915_request_power_well() > > and i915_release_power_well() wrongly but still continues probing, > > even though it doesn't work at all. > > > > In this patch, both functions are changed to return an error in case > > of uninitialized state instead of WARN_ON(), so that HD-audio driver > > can give up HDMI controller initialization at the right time. > > > > Cc: [3.15] > > Signed-off-by: Takashi Iwai > > Acked-by: Daniel Vetter > > I guess you'll merge this through the sound tree? Yes, if you don't mind it. thanks, Takashi