From: Takashi Iwai Subject: Re: [PATCH 1/1] Improved MacBook 3,1 support Date: Mon, 18 May 2009 15:18:10 +0200 Message-ID: References: <4A113DFB.1080106@letorbi.de> <4A115C6B.1070401@letorbi.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 1AF831037E3 for ; Mon, 18 May 2009 15:18:11 +0200 (CEST) In-Reply-To: <4A115C6B.1070401@letorbi.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Torben Schulz Cc: Alsa-Devel List-Id: alsa-devel@alsa-project.org At Mon, 18 May 2009 15:02:35 +0200, Torben Schulz wrote: > > Takashi Iwai wrote: > > Thanks, the patch looks almost good to me. > > But, please run $LINUX/scripts/checkpatch.pl and fix the warnings > > about the coding style. > [...] > > Could repost the fixed patch later? > > Sorry for not running checkpatch.pl - I simply forgot it. I applied your suggestion and fixed all warnings, so the patch should be ready now. It's now also diff'ed against the latest snapshot. > > This patch adds support for MacBook 3,1 sound by adding a model new "mb31" with the appropriate init verbs, mixers and channel modes to the ALC883 configuration. patch_alc882() and patch_alc883() are modified to handle the MacBook 3,1 sound-chip (Realtek ALC889A) correctly. > > Signed-off-by: Torben Schulz Thanks! Applied now. Takashi