From: Takashi Iwai Subject: Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table Date: Wed, 21 Nov 2007 10:53:54 +0100 Message-ID: References: <1195552283.23700.166.camel@queen.suse.de> <20071120123102.03bdaa67@the-village.bc.nu> <1195568360.23700.202.camel@queen.suse.de> <4742EFBE.6030407@keyaccess.nl> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 4186124BCD for ; Wed, 21 Nov 2007 11:28:16 +0100 (CET) In-Reply-To: <4742EFBE.6030407@keyaccess.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Rene Herman Cc: ALSA devel , linux-kernel , "yakui.zhao" , "Li, Shaohua" , akpm , trenn@suse.de, Alan Cox , Bjorn Helgaas List-Id: alsa-devel@alsa-project.org At Tue, 20 Nov 2007 15:31:26 +0100, Rene Herman wrote: > > On 20-11-07 15:19, Thomas Renninger wrote: > > > At the end is some example code how things could get even more cleaned > > up. It shows how I think pnp layer and one example driver would get > > adjusted. There are not that much drivers making use of > > pnp_resource_change... > > The ALSA ISA-PnP drivers do in what I personally consider a bad layering > violation. Brought up not doing that a while ago on alsa-devel, but no > discussion ensued. If the PnP maintainer(s) agree with me though, I'd be > more than happy to rip all of that out of ALSA. I'm fine with removal of that stuff now. It was implemented in that way because there was no proper way to re-assign ISA PnP resources on 2.4 kernel time. On 2.6, it makes no longer any sense (except for compatibility, but this is almost no problem for PnP boards). thanks, Takashi