From: Takashi Iwai Subject: Re: CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups) Date: Tue, 05 Sep 2006 17:26:03 +0200 Message-ID: References: <20060831123706.GC3923@elf.ucw.cz> <20060831110436.995bdf93.rdunlap@xenotime.net> <20060902231509.GC13031@elf.ucw.cz> <20060902213046.dd9bf569.rdunlap@xenotime.net> <20060905080813.GE1958@elf.ucw.cz> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id ED32225F for ; Tue, 5 Sep 2006 17:26:10 +0200 (MEST) In-Reply-To: <20060905080813.GE1958@elf.ucw.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Pavel Machek Cc: Andrew Morton , alsa-devel@alsa-project.org, kernel list , "Randy.Dunlap" , pshou@realtek.com.tw, perex@suse.cz List-Id: alsa-devel@alsa-project.org At Tue, 5 Sep 2006 10:08:14 +0200, Pavel Machek wrote: > > > > Looks reasonable to me. Will you do the patch or should I ? > > > > Please (you) go ahead with it. > > Does it look okay? > > Signed-off-by: Pavel Machek > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle > index 6d2412e..d8e51a6 100644 > --- a/Documentation/CodingStyle > +++ b/Documentation/CodingStyle > @@ -46,6 +46,16 @@ used for indentation, and the above exam > > Get a decent editor and don't leave whitespace at the end of lines. > > +Bitfield variables should be indented like this: > + > + unsigned int foo :1; > + > +Avoid extra spaces around ! operator, and do not place spaces around (s. > + > + if (!buffer) > + > +is okay, if ( ! buffer ) is just ugly. > + I know I belong to an endagered species, but I still find if (! buffer) ... isn't so ugly. Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642