Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897C3C433F5 for ; Tue, 11 Jan 2022 16:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349809AbiAKQJT (ORCPT ); Tue, 11 Jan 2022 11:09:19 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:57588 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349801AbiAKQJT (ORCPT ); Tue, 11 Jan 2022 11:09:19 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 0B79E1F3B8; Tue, 11 Jan 2022 16:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1641917358; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2gg+/L0HZ5tyMQWbHtUsJyCbwGtfjLqKMlD+joksRQ=; b=ZthQwQbW4V4HGZgW6ABIijkgdhpmLua7sHYbombLBY97+tZdeMyIH52yToqOi87OZ3T6+I H98rJmasYI4TsihyC8ezwWuhM26eJRTDLgMvuq54VhKwX9JXYQsM1SkpJchQJ3UXz7f7WH kRwgjETtAd7gbkuC0TyfN2oO4VpwC1s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1641917358; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q2gg+/L0HZ5tyMQWbHtUsJyCbwGtfjLqKMlD+joksRQ=; b=cC1a897iDSVlXNHATuLNT8IYUAjqBHuong6jlzN/TGbV70g4bi+jKsoxsHit8FarQCVoQ9 NcSefpzhh+iP5pCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id D85B5A3B83; Tue, 11 Jan 2022 16:09:17 +0000 (UTC) Date: Tue, 11 Jan 2022 17:09:17 +0100 Message-ID: From: Takashi Iwai To: Dan Carpenter Cc: James Schulman , Lucas Tanure , David Rhodes , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: cs35l41: fix double free on error in probe() In-Reply-To: <20220111072232.GG11243@kili> References: <20220111072232.GG11243@kili> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Tue, 11 Jan 2022 08:22:32 +0100, Dan Carpenter wrote: > > If we encounter an error after the kfree(acpi_hw_cfg); then the goto > err; will result in a double free. > > Fixes: 7b2f3eb492da ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems") > Signed-off-by: Dan Carpenter Thanks, applied now. Takashi