Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE08DC2B9F4 for ; Tue, 22 Jun 2021 19:43:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C51861361 for ; Tue, 22 Jun 2021 19:43:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C51861361 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2DE6285D; Tue, 22 Jun 2021 21:42:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2DE6285D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624390991; bh=Cg0xEaBf7vwYBM9feQWOjx6AVghos3OHMYetoEP8Zfk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Xri0fnJlvqhGjm3BQu2jEGnFok1DfHYZSeD4R30Aes5Olj4uUfuz+CukteLloSWvf ptkKE1PIbE+mn6wWRR7zIS5pygcpal22mXyNS0+msnhrXbi+RSEwDOziEjcUikmux4 04tJZdKvx6/6Eul8QbuWC+Wk4FApR5TEKk5KfV2U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B4934F8025F; Tue, 22 Jun 2021 21:42:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B76F2F80268; Tue, 22 Jun 2021 21:42:18 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27069F80161 for ; Tue, 22 Jun 2021 21:42:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27069F80161 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="yJEH/vM2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4IyzbTZt" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 7EDC42195D; Tue, 22 Jun 2021 19:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624390932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88a9gNIHlJrFd5zEra8SjUbJ2X9Q1+IcypfZd+nkK5M=; b=yJEH/vM2jgSmu7K/0AXOVuCOtfcGxs+Aiu4a/IIpwRvU0uqrh3mN13gce3BtNqK8yT8ZHR 3e+GcgReGLCJ0hIEz4OBuLbUy+y2rgMOh3hjCmv1+lzZ8DkKooe4dGf2T+NBoz1r1k0gEF SBdx/AQylAL4wQyA90CSbQAd4+FmMk4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624390932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=88a9gNIHlJrFd5zEra8SjUbJ2X9Q1+IcypfZd+nkK5M=; b=4IyzbTZtHmkHkoTeJbW1O6+nEC/IUZYLgQz3o12wQUfgHyq6iwqGaJtn+s1I3y530mTnZC Q95rxDrcfbC2rrBQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 75DE3A3B8D; Tue, 22 Jun 2021 19:42:10 +0000 (UTC) Date: Tue, 22 Jun 2021 21:42:10 +0200 Message-ID: From: Takashi Iwai To: "Geoffrey D. Bennett" Subject: Re: [PATCH 01/17] ALSA: usb-audio: scarlett2: Fix wrong resume call In-Reply-To: <49721219f45b7e175e729b0d9d9c142fd8f4342a.1624379707.git.g@b4.vu> References: <49721219f45b7e175e729b0d9d9c142fd8f4342a.1624379707.git.g@b4.vu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Hin-Tak Leung , alsa-devel@alsa-project.org, Vladimir Sadovnikov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 22 Jun 2021 19:00:49 +0200, Geoffrey D. Bennett wrote: > > From: Takashi Iwai > > The current way of the scarlett2 mixer code managing the > usb_mixer_elem_info object is wrong in two ways: it passes its > internal index to the head.id field, and the val_type field is > uninitialized. This ended up with the wrong execution at the resume > because a bogus unit id is passed wrongly. Also, in the later code > extensions, we'll have more mixer elements, and passing the index will > overflow the unit id size (of 256). > > This patch corrects those issues. It introduces a new value type, > USB_MIXER_BESPOKEN, which indicates a non-standard mixer element, and > use this type for all scarlett2 mixer elements, as well as > initializing the fixed unit id 0 for avoiding the overflow. > > Tested-by: Geoffrey D. Bennett > Cc: > Signed-off-by: Takashi Iwai When submitting a patch, you have to your Signed-off-by line even if you are no author. Could you give it? Just reply with a proper SOB, then I'll fix manually. thanks, Takashi