Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D35C10F25 for ; Mon, 9 Mar 2020 18:57:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5D5420866 for ; Mon, 9 Mar 2020 18:57:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="GjGV9JzV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5D5420866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4AB0A169A; Mon, 9 Mar 2020 19:56:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4AB0A169A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583780245; bh=0muVaja/CCLs8YpZowJpjkPGiaV7k9WV0wey3rPiz+g=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GjGV9JzVHKf+KejaB817wS2yg1TVgdAJmWmRug2+rkiGIrBE8VDDiM7H6KJ28wkTN RYgyGgGSZGRxgXl+RNAY0cF4+1LyC8+yJE3Ipgsf/12ld5HV3Q3KNR5JEwiNPYIz8U 9XPMyc5rfubRqoCGquw/UkB/nbXDFg0or9VHpYn8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C3500F801A3; Mon, 9 Mar 2020 19:56:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 95C0EF801EB; Mon, 9 Mar 2020 19:56:32 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 77CF3F800B5 for ; Mon, 9 Mar 2020 19:56:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 77CF3F800B5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 04CD5B03B for ; Mon, 9 Mar 2020 18:56:26 +0000 (UTC) Date: Mon, 09 Mar 2020 19:56:25 +0100 Message-ID: From: Takashi Iwai To: alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: pcm: oss: Simplify plugin frame size calculations In-Reply-To: <20200309185057.13974-1-tiwai@suse.de> References: <20200309185057.13974-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 09 Mar 2020 19:50:57 +0100, Takashi Iwai wrote: > > Both snd_pcm_plug_client_size() and snd_pcm_plug_slave_size() do the > almost same calculations of calling src_frames() and dst_frames() in > the chain, but just to the different directions with each other. > > This patch simplifies those functions. Now they return -EINVAL for > the invalid direction, but practically seen, there is no functional > changes at all. > > Signed-off-by: Takashi Iwai Sorry, scratch this, an old version was sent here. Will submit the right one. Takashi