From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls() Date: Fri, 26 Jul 2019 14:26:31 +0200 Message-ID: References: <20190726021442.21177-1-baijiaju1990@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20190726021442.21177-1-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Jia-Ju Bai Cc: tglx@linutronix.de, gregkh@linuxfoundation.org, perex@perex.cz, rfontana@redhat.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, 26 Jul 2019 04:14:42 +0200, Jia-Ju Bai wrote: > > In build_adc_controls(), there is an if statement on line 773 to check > whether ak->adc_info is NULL: > if (! ak->adc_info || > ! ak->adc_info[mixer_ch].switch_name) > > When ak->adc_info is NULL, it is used on line 792: > knew.name = ak->adc_info[mixer_ch].selector_name; > > Thus, a possible null-pointer dereference may occur. > > To fix this bug, referring to lines 773 and 774, ak->adc_info > and ak->adc_info[mixer_ch].selector_name are checked before being used. > > This bug is found by a static analysis tool STCheck written by us. > > Signed-off-by: Jia-Ju Bai Applied, thanks. Takashi