From: Takashi Iwai Subject: Re: [PATCH] ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally Date: Fri, 27 Jul 2018 07:11:11 +0200 Message-ID: References: <20180725201556.21136-1-pierre-louis.bossart@linux.intel.com> <201807262256.hwoGoA35%fengguang.wu@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id EEF4F26778A for ; Fri, 27 Jul 2018 07:11:13 +0200 (CEST) In-Reply-To: <201807262256.hwoGoA35%fengguang.wu@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: kbuild test robot Cc: alsa-devel@alsa-project.org, Pierre-Louis Bossart , liam.r.girdwood@linux.intel.com, vkoul@kernel.org, broonie@kernel.org, kbuild-all@01.org List-Id: alsa-devel@alsa-project.org On Thu, 26 Jul 2018 16:51:55 +0200, kbuild test robot wrote: > > Hi Pierre-Louis, > > I love your patch! Yet something to improve: > > [auto build test ERROR on sound/for-next] > [also build test ERROR on v4.18-rc6 next-20180725] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Pierre-Louis-Bossart/ALSA-memalloc-declare-snd_sgbuf_aligned_pages-unconditionally/20180726-192035 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > config: alpha-allyesconfig (attached as .config) > compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.2.0 make.cross ARCH=alpha > > All errors (new ones prefixed by >>): > > In file included from include/sound/pcm.h:27:0, > from sound/core/pcm_iec958.c:11: > include/sound/memalloc.h: In function 'snd_sgbuf_aligned_pages': > >> include/sound/memalloc.h:75:17: error: 'PAGE_SIZE' undeclared (first use in this function); did you mean 'TASK_SIZE'? > return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; > ^~~~~~~~~ > TASK_SIZE OK, we need to include in this header file. Pierre, care to resend with the fix? thanks, Takashi