From: Takashi Iwai Subject: Re: [PATCH v4 09/15] ALSA: usb-audio: conditional interface altsetting Date: Mon, 07 Oct 2013 21:31:17 +0200 Message-ID: References: <1381091480-23636-1-git-send-email-eldad@fogrefinery.com> <1381091480-23636-10-git-send-email-eldad@fogrefinery.com> <5252FC2A.306@ladisch.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7EB26265193 for ; Mon, 7 Oct 2013 21:28:28 +0200 (CEST) In-Reply-To: <5252FC2A.306@ladisch.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Clemens Ladisch Cc: Eldad Zack , Nikolay Martynov , alsa-devel@alsa-project.org, Daniel Mack List-Id: alsa-devel@alsa-project.org At Mon, 07 Oct 2013 20:23:38 +0200, Clemens Ladisch wrote: > > Eldad Zack wrote: > > On Mon, 7 Oct 2013, Takashi Iwai wrote: > >> Eldad Zack wrote: > >>> On some devices, if the endpoint for the other direction is in use, > >>> setting one interface will shutdown the other (in use) endpoint. > >>> This patch moves all of the alternate setting operations for pcm > >>> ops to one function which checks if we can do so. > >>> > >>> If current alternate is 0, it is safe to set. > >> > >> Is this check needed for all devices? > > > > I'm not sure, I only have this one device to test with. > > In theory, interfaces are independent, but in practice, the firmware > does whatever it does. For implicit feedback devices, it's likely that > they were expected to be used in full duplex mode only. For the implicit feedback devices, I find the change being good, too. But my concern is rather that this filtering is applied to all cases, no matter whether it's implicit fb or not. In such cases, the assignment of full duplex streams is just casual, and they are likely individual. thanks, Takashi