From: Takashi Iwai Subject: Re: [PATCH 1/2] ucm: fix seg fault in execute_cset() Date: Fri, 19 Aug 2011 10:42:12 +0200 Message-ID: References: <20110819080525.9512.90201.stgit@localhost6.localdomain6> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 8A0BA103905 for ; Fri, 19 Aug 2011 10:42:13 +0200 (CEST) In-Reply-To: <20110819080525.9512.90201.stgit@localhost6.localdomain6> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Lu Guanqun Cc: ALSA List-Id: alsa-devel@alsa-project.org At Fri, 19 Aug 2011 16:05:25 +0800, Lu Guanqun wrote: > > When there's no space in 'cset', 'pos' gets NULL, dereferencing 'pos' gets a > seg fault. We need to be more robust. > > Signed-off-by: Lu Guanqun Thanks, applied both now. Takashi > --- > src/ucm/main.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/src/ucm/main.c b/src/ucm/main.c > index 8e9a85d..9ecbe43 100644 > --- a/src/ucm/main.c > +++ b/src/ucm/main.c > @@ -196,7 +196,8 @@ static int execute_cset(snd_ctl_t *ctl, char *cset) > goto __fail; > err = 0; > __fail: > - *pos = ' '; > + if (pos != NULL) > + *pos = ' '; > > if (id != NULL) > free(id); >