From: Takashi Iwai Subject: Re: Lost dB volumes on USB headset between 2.6.38 and 3.0 Date: Thu, 18 Aug 2011 17:18:09 +0200 Message-ID: References: <4E410361.7010808@canonical.com> <4E410E7D.8050903@ladisch.de> <4E4117C9.2090100@colin.guthr.ie> <4E4A6338.6020309@colin.guthr.ie> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id E564624416 for ; Thu, 18 Aug 2011 17:18:12 +0200 (CEST) In-Reply-To: <4E4A6338.6020309@colin.guthr.ie> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Colin Guthrie Cc: ALSA Development Mailing List , Clemens Ladisch , David Henningsson List-Id: alsa-devel@alsa-project.org At Tue, 16 Aug 2011 13:31:52 +0100, Colin Guthrie wrote: > > > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c > > index c04d7c7..cdd19d7 100644 > > --- a/sound/usb/mixer.c > > +++ b/sound/usb/mixer.c > > @@ -152,6 +152,7 @@ static inline void check_mapped_dB(const struct usbmix_name_map *p, > > if (p && p->dB) { > > cval->dBmin = p->dB->min; > > cval->dBmax = p->dB->max; > > + cval->initialized = 1; > > } > > } > > > > @@ -1092,7 +1093,7 @@ static void build_feature_ctl(struct mixer_build *state, void *raw_desc, > > " Switch" : " Volume"); > > if (control == UAC_FU_VOLUME) { > > check_mapped_dB(map, cval); > > - if (cval->dBmin < cval->dBmax) { > > + if (cval->dBmin < cval->dBmax || !cval->initialized) { > > kctl->tlv.c = mixer_vol_tlv; > > kctl->vd[0].access |= > > SNDRV_CTL_ELEM_ACCESS_TLV_READ | > > > > Not had a chance to test this yet but I will when I get a moment. Any chance to test the patch? Takashi