From: Takashi Iwai Subject: Re: error in snd_pcm_drain() Date: Thu, 05 Jul 2007 17:32:04 +0200 Message-ID: References: <200707051937.42073.linux@audioscience.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 0692F1038DB for ; Thu, 5 Jul 2007 17:32:09 +0200 (CEST) In-Reply-To: <200707051937.42073.linux@audioscience.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Eliot Blennerhassett Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 05 Jul 2007 19:37:41 +1200, Eliot Blennerhassett wrote: > > Maybe an error in snd_pcm_drain - not sure what effect it might have... > > snd_pcm_group_for_each_entry(s, substream) { > runtime = s->runtime; > ... > } > up_read(&snd_pcm_link_rwsem); > snd_pcm_stream_lock_irq(substream); > > /* pcm_native.c around line 1491: */ > /* error? runtime has been changed by group_for_each > should use substream->runtime instead? > */ Maybe a bit safer, but in the end it's same because the status of linked streams should be identical. Takashi > > /* resume pause */ > if (runtime->status->state == SNDRV_PCM_STATE_PAUSED) > snd_pcm_pause(substream, 0); > > > -- > Eliot > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >