Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6234C2B9F4 for ; Tue, 22 Jun 2021 07:01:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E9496128E for ; Tue, 22 Jun 2021 07:01:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E9496128E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 20C0686E; Tue, 22 Jun 2021 09:00:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 20C0686E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624345277; bh=1HESweuCMzsjThUHmIHeHhWBvq6gfNc3dWsvc7uLgiI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mHgjbEIKcs/OQj83dq8X52fGLbWZs1tQl367HMPofl1OLmv5+MbWgNb/YtcmtZtt2 eusSU45s0ziTcSdJIX3NF5+2f6GK7XnACsb5+rQ+W1J4EWqYQEo4V4zPL2LKqUuYk1 n6q8byJY1SUFLZElbHR/uKOn7ucrMTbFFEDHluj0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8FD50F8025F; Tue, 22 Jun 2021 09:00:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8BF5BF80268; Tue, 22 Jun 2021 09:00:24 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2F639F800E1 for ; Tue, 22 Jun 2021 09:00:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2F639F800E1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="wLt019y8"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="E7zht7o9" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A595D1FD55; Tue, 22 Jun 2021 07:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624345220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+fkwFTY9nxg+azlt8VuCiRTf8yIRf7myqY27iiSBed8=; b=wLt019y8ZjGe7LycmsSWfEezhIMOpLku38VU3dmKO8DGRCXViclbZWKc53c0BzCeRL+jG2 7tOQiraNCe9Y0FQObgV+YuvxHveY2IRBt45UFtKlG2NnETRNqX2BndUozotduYvFI56DV0 y2tUOMAe3Yb40rg6oCQUK9+R7lyhnqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624345220; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+fkwFTY9nxg+azlt8VuCiRTf8yIRf7myqY27iiSBed8=; b=E7zht7o9LPBJ0Elez5k853SxUxHJUD/KLuSbj3M2l1k2mW/NndWUKiXJdTwmSE3rRxk0yn AWdyFa4cjBPEn8CQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 98B00A3B84; Tue, 22 Jun 2021 07:00:19 +0000 (UTC) Date: Tue, 22 Jun 2021 09:00:19 +0200 Message-ID: From: Takashi Iwai To: "Geoffrey D. Bennett" Subject: Re: [PATCH 16/31] ALSA: usb-audio: scarlett2: Add Gen 3 mixer support In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Hin-Tak Leung , alsa-devel@alsa-project.org, Vladimir Sadovnikov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 21 Jun 2021 20:09:48 +0200, Geoffrey D. Bennett wrote: > > Add mixer support for the Focusrite Scarlett 4i4, 8i6, 18i8, and 18i20 > Gen 3 devices. > > Signed-off-by: Geoffrey D. Bennett > --- > sound/usb/mixer.c | 2 +- > sound/usb/mixer_quirks.c | 4 + > sound/usb/mixer_scarlett_gen2.c | 260 +++++++++++++++++++++++++++++--- > 3 files changed, 246 insertions(+), 20 deletions(-) > > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c > index 428d581f988f..ba4aa1eacb04 100644 > --- a/sound/usb/mixer.c > +++ b/sound/usb/mixer.c > @@ -50,7 +50,7 @@ > #include "mixer_quirks.h" > #include "power.h" > > -#define MAX_ID_ELEMS 256 > +#define MAX_ID_ELEMS 512 This change requires the explanation. Usually the unit id is a byte per definition, so it can't be over 256. thanks, Takashi