From: Takashi Iwai Subject: Re: [PATCH v3] ASoC: codec: hdac_hdmi: fix pin connections at cvt enable Date: Thu, 13 Jun 2019 13:58:19 +0200 Message-ID: References: <20190613115412.13921-1-kai.vehmanen@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4F353F8076F for ; Thu, 13 Jun 2019 13:58:20 +0200 (CEST) In-Reply-To: <20190613115412.13921-1-kai.vehmanen@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Kai Vehmanen Cc: libin.yang@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com List-Id: alsa-devel@alsa-project.org On Thu, 13 Jun 2019 13:54:12 +0200, Kai Vehmanen wrote: > > In display codecs supported by hdac_hdmi, the connection indices are > shared by all converters. At boot and resume from suspend, > the connection state may be reset to default values. > > In case of multiple connected pins (multiple monitors connected > with audio capability), routing and mute status of pins that > are not connected to any PCM, may interfere with other pins. > E.g. after resume from S3 with multiple monitors, unless > all converters are in active use, playback to some PCMs may > be muted due to the default settings of unrelated converters. > > Avoid this by ensuring all pin:cvt selections are correct > in codec whenever a converter is enabled for playback. > > Signed-off-by: Kai Vehmanen Reviewed-by: Takashi Iwai thanks, Takashi